Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add self-provided themes #2223

Closed
wants to merge 19 commits into from
Closed

feat: add self-provided themes #2223

wants to merge 19 commits into from

Conversation

jaeheonji
Copy link
Member

Now zellij provides its own variety of themes.
The types of themes provided at this point include those that existed in the example folder.

And the example folder will contain only examples in accordance with the intent.

@imsnif
Copy link
Member

imsnif commented Mar 6, 2023

This is great @jaeheonji !! I'd like to release a version tomorrow morning. Do you think this will be ready in time?

@jaeheonji
Copy link
Member Author

@imsnif
I think I'm almost ready. But only one weird thing is, the current e2e test doesn't pass. Exactly, the timeout occurs, but I don't know why.

@naosense
Copy link
Contributor

naosense commented Mar 6, 2023

last time I also encountered this, the e2e failure disappeared after I recommit the code

@jaeheonji
Copy link
Member Author

Thanks for letting me know. I'll try to make a PR after re-commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants