Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rust 1.67 #2375

Merged
merged 12 commits into from
May 9, 2023
Merged

Use rust 1.67 #2375

merged 12 commits into from
May 9, 2023

Conversation

har7an
Copy link
Contributor

@har7an har7an commented Apr 18, 2023

Updates the rust toolchain to 1.67 and updates a few dependencies on the way. Fixes #2295 partially.

I chose to go with Rust 1.67 because on the one hand every rust version update brings the potential chance of breaking zellij in unexpected ways, and on the other hand Rust 1.68 doesn't bring new features that are particularly interesting for us.

@har7an har7an force-pushed the feature/use-rust-1.67 branch from 164ac29 to 242d5c5 Compare April 18, 2023 16:06
@har7an har7an temporarily deployed to cachix April 18, 2023 16:07 — with GitHub Actions Inactive
@har7an har7an force-pushed the feature/use-rust-1.67 branch from 242d5c5 to 67779e9 Compare April 25, 2023 14:59
@har7an har7an force-pushed the feature/use-rust-1.67 branch from a6383c6 to 33aca69 Compare May 3, 2023 17:05
har7an added 10 commits May 8, 2023 18:18
for crates.io to catch up, which is obsolete with rust 1.66 and up.
Cargo does that on its own now. See
rust-lang/cargo#11062
instead of assembling it on demand throughout the codebase.
as a convenient shorthand for `cargo xtask run --data-dir
$PROJECT_ROOT/zellij-utils/assets`.
as a shorthand for 'cargo xtask run --quick-run'
and specify dependency only once inside `zellij-utils`, not inside the
zellij root crate.
and re-export the dependency from zellij-utils, to avoid duplicate
(incompatible) includes from inside zellij-utils and the root crate.
@har7an har7an force-pushed the feature/use-rust-1.67 branch from 33aca69 to 851e85e Compare May 8, 2023 16:26
@har7an har7an temporarily deployed to cachix May 8, 2023 16:26 — with GitHub Actions Inactive
@har7an har7an temporarily deployed to cachix May 8, 2023 17:00 — with GitHub Actions Inactive
@har7an har7an temporarily deployed to cachix May 8, 2023 17:02 — with GitHub Actions Inactive
@har7an har7an merged commit 30d0cff into zellij-org:main May 9, 2023
@har7an har7an deleted the feature/use-rust-1.67 branch May 9, 2023 02:43
renovate bot referenced this pull request in scottames/dots Jun 19, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [aquaproj/aqua-registry](https://github.com/aquaproj/aqua-registry)
| minor | `v4.19.0` -> `v4.20.0` |
| [zellij-org/zellij](https://github.com/zellij-org/zellij) | minor |
`v0.36.0` -> `v0.37.0` |

---

### Release Notes

<details>
<summary>aquaproj/aqua-registry</summary>

###
[`v4.20.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.20.0)

[Compare
Source](https://github.com/aquaproj/aqua-registry/compare/v4.19.0...v4.20.0)


[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.20.0)
| [Pull
Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.20.0)
| aquaproj/aqua-registry@v4.19.0...v4.20.0

#### 🎉 New Packages


[#&#8203;13132](https://github.com/aquaproj/aqua-registry/issues/13132)
[segmentio/golines](https://github.com/segmentio/golines): A golang
formatter that fixes long lines
[@&#8203;iwata](https://github.com/iwata)

#### Fixes


[#&#8203;13143](https://github.com/aquaproj/aqua-registry/issues/13143)
[terraform-linters/tflint](https://github.com/terraform-linters/tflint):
Support old versions

</details>

<details>
<summary>zellij-org/zellij</summary>

###
[`v0.37.0`](https://github.com/zellij-org/zellij/releases/tag/v0.37.0)

[Compare
Source](https://github.com/zellij-org/zellij/compare/v0.36.0...v0.37.0)

In this release we've done a lot of work on our WebAssembly / WASI
plugin system and are very excited to invite adventurous Rust developers
to come pioneer our plugin system with us. To read more, please see the
official [Plugin
Documentation](https://zellij.dev/documentation/plugins.html).

Please also drop by our Discord or Matrix and show us the plugins you're
working on!

#### Other Highlights

- Some basic themes are now included with the release, give it a try by
starting Zellij with `zellij options --theme catppuccin-mocha`
-   Layouts now support environment variables and tilde expansions
-   We can now provide a `--cwd` option when starting Zellij

#### All changes

- fix(plugin): respect hide session option on compact-bar by
[@&#8203;pedromfedricci](https://github.com/pedromfedricci) in
[https://github.com/zellij-org/zellij/pull/2368](https://github.com/zellij-org/zellij/pull/2368)
- feat: Add layout configuration to exclude panes from tab sync by
[@&#8203;on3iro](https://github.com/on3iro) in
[https://github.com/zellij-org/zellij/pull/2314](https://github.com/zellij-org/zellij/pull/2314)
- Fix 2205 - Support cwd by
[@&#8203;Kangaxx-0](https://github.com/Kangaxx-0) in
[https://github.com/zellij-org/zellij/pull/2290](https://github.com/zellij-org/zellij/pull/2290)
- feat(plugins): reload plugin at runtime by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2372](https://github.com/zellij-org/zellij/pull/2372)
- Update architecture doc by
[@&#8203;Kangaxx-0](https://github.com/Kangaxx-0) in
[https://github.com/zellij-org/zellij/pull/2371](https://github.com/zellij-org/zellij/pull/2371)
- feat(themes): add nightfox themes by
[@&#8203;EdenEast](https://github.com/EdenEast) in
[https://github.com/zellij-org/zellij/pull/2384](https://github.com/zellij-org/zellij/pull/2384)
- feat: provide default themes by
[@&#8203;jaeheonji](https://github.com/jaeheonji) in
[https://github.com/zellij-org/zellij/pull/2307](https://github.com/zellij-org/zellij/pull/2307)
- feat(plugins): update and render plugins asynchronously by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2410](https://github.com/zellij-org/zellij/pull/2410)
- feat(layout): Support environment variables in cwd
([#&#8203;2288](https://github.com/zellij-org/zellij/issues/2288)) by
[@&#8203;shahamran](https://github.com/shahamran) in
[https://github.com/zellij-org/zellij/pull/2291](https://github.com/zellij-org/zellij/pull/2291)
- Add file path context to all IO errors in ConfigError by
[@&#8203;Imberflur](https://github.com/Imberflur) in
[https://github.com/zellij-org/zellij/pull/2412](https://github.com/zellij-org/zellij/pull/2412)
- fix(e2e): fix flaky locked mode test by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2413](https://github.com/zellij-org/zellij/pull/2413)
- Fix error loading non-existant themes directory and use default themes
as the base when merging by
[@&#8203;Imberflur](https://github.com/Imberflur) in
[https://github.com/zellij-org/zellij/pull/2411](https://github.com/zellij-org/zellij/pull/2411)
- improve build/ci times by
[@&#8203;tlinford](https://github.com/tlinford) in
[https://github.com/zellij-org/zellij/pull/2396](https://github.com/zellij-org/zellij/pull/2396)
- Do not unwrap() the sticky bit setting! by
[@&#8203;valpackett](https://github.com/valpackett) in
[https://github.com/zellij-org/zellij/pull/2424](https://github.com/zellij-org/zellij/pull/2424)
- Use rust 1.67 by [@&#8203;har7an](https://github.com/har7an) in
[https://github.com/zellij-org/zellij/pull/2375](https://github.com/zellij-org/zellij/pull/2375)
- Fix issue 2421 - Update config file output by
[@&#8203;Kangaxx-0](https://github.com/Kangaxx-0) in
[https://github.com/zellij-org/zellij/pull/2443](https://github.com/zellij-org/zellij/pull/2443)
- feat(plugins): Plugin workers and strider by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2449](https://github.com/zellij-org/zellij/pull/2449)
- fix: cwd of newtab action by
[@&#8203;onichandame](https://github.com/onichandame) in
[https://github.com/zellij-org/zellij/pull/2455](https://github.com/zellij-org/zellij/pull/2455)
- feat(wasm-plugin-system): major overhaul and some goodies by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2510](https://github.com/zellij-org/zellij/pull/2510)
- feat(plugins): extensive plugin api by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2516](https://github.com/zellij-org/zellij/pull/2516)
- fix: runtime panic because of local cache by
[@&#8203;jaeheonji](https://github.com/jaeheonji) in
[https://github.com/zellij-org/zellij/pull/2522](https://github.com/zellij-org/zellij/pull/2522)
- fix(output): do not hide cursor on a render that does not include
visual assets by [@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2528](https://github.com/zellij-org/zellij/pull/2528)
- fix(screen): focus tab as well as pane when launching existing plugin
by [@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2530](https://github.com/zellij-org/zellij/pull/2530)
- fix(strider): clear search term on ESC by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2531](https://github.com/zellij-org/zellij/pull/2531)
- fix(plugins): only listen to hd if a plugin is subscribed to hd events
by [@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2529](https://github.com/zellij-org/zellij/pull/2529)
- fix(logs): suppress debug logs when not debugging by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2532](https://github.com/zellij-org/zellij/pull/2532)
- fix(plugins): allow loading relative urls by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2539](https://github.com/zellij-org/zellij/pull/2539)
- feat(plugins): plugin pane state events by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2545](https://github.com/zellij-org/zellij/pull/2545)
- performance(plugins): use a debounced fs watcher by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2546](https://github.com/zellij-org/zellij/pull/2546)
- feat(plugins): more plugin api methods by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2550](https://github.com/zellij-org/zellij/pull/2550)
- refactor(plugins): improve api by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2552](https://github.com/zellij-org/zellij/pull/2552)
- feat(plugins): strider improvements by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2551](https://github.com/zellij-org/zellij/pull/2551)
- docs(plugins): document the zellij-tile events and commands api by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2554](https://github.com/zellij-org/zellij/pull/2554)
- docs(plugins): better zellij-tile-docs by
[@&#8203;imsnif](https://github.com/imsnif) in
[https://github.com/zellij-org/zellij/pull/2560](https://github.com/zellij-org/zellij/pull/2560)

#### New Contributors

- [@&#8203;on3iro](https://github.com/on3iro) made their first
contribution in
[https://github.com/zellij-org/zellij/pull/2314](https://github.com/zellij-org/zellij/pull/2314)
- [@&#8203;Kangaxx-0](https://github.com/Kangaxx-0) made their first
contribution in
[https://github.com/zellij-org/zellij/pull/2290](https://github.com/zellij-org/zellij/pull/2290)
- [@&#8203;EdenEast](https://github.com/EdenEast) made their first
contribution in
[https://github.com/zellij-org/zellij/pull/2384](https://github.com/zellij-org/zellij/pull/2384)
- [@&#8203;shahamran](https://github.com/shahamran) made their first
contribution in
[https://github.com/zellij-org/zellij/pull/2291](https://github.com/zellij-org/zellij/pull/2291)
- [@&#8203;Imberflur](https://github.com/Imberflur) made their first
contribution in
[https://github.com/zellij-org/zellij/pull/2412](https://github.com/zellij-org/zellij/pull/2412)
- [@&#8203;valpackett](https://github.com/valpackett) made their first
contribution in
[https://github.com/zellij-org/zellij/pull/2424](https://github.com/zellij-org/zellij/pull/2424)
- [@&#8203;onichandame](https://github.com/onichandame) made their
first contribution in
[https://github.com/zellij-org/zellij/pull/2455](https://github.com/zellij-org/zellij/pull/2455)

**Full Changelog**:
zellij-org/zellij@v0.36.0...v0.37.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/scottames/dots).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMjYuMCIsInVwZGF0ZWRJblZlciI6IjM1LjEyNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

future incompatible dependencies
1 participant