feat(cli): list-sessions show newest sessions last, for better user experience
#3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by putting the most recent sessions last, the user won't need to scroll back up to see active sessions when there are a lot of resurrectable sessions.
the `--reverse` flag reverts sorting order back to the old "newest sessions first". also updated call sites of `list_sessions` and `print_sessions` with `reverse: true`, to keep the original behavior everywhere else except the output of `list-sessions` subcommand.
jaeheonji
changed the title
list-sessions show newest sessions last, for better user experiencelist-sessions show newest sessions last, for better user experience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
list-sessionssort from newest to oldest, so, recent sessions will be pushed up out of screen if there are a lot of resurrectable sessions. Therefore the user likely have to scroll back up to see which active sessions they want to attach to.IMO it would be a much better user experience to sort from oldest to newest.
This PR changes the default
sort_byorder inzellij::sessions::print_sessions()fromDurationascending to descending, and added a--reverseflag to thelist-sessionssubcommand for the old behavior.current (newest to oldest)
modified (oldest to newest)
modified, reverse (newest to oldest)