Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy and paste not working due to kitty mode #3460

Closed
wants to merge 1 commit into from

Conversation

towry
Copy link

@towry towry commented Jun 28, 2024

Fix #3421

Some plugin are using the write and write_chars methods but it doesn't take care of the kitty keyboard protocol, see

let action = Action::Write(None, bytes, false);

@imsnif
Copy link
Member

imsnif commented Jun 28, 2024

Can you help me understand what you are trying to fix? This doesn't seem related to #3421 - but maybe I'm missing something?

@towry
Copy link
Author

towry commented Jun 28, 2024

I am trying to fix the paste not working in neovim and helix issue, the changes works (build and tested), the changes is related to #3421.

The link in the above related to another issue with plugin, for example, in plugin write_chars not working any more if kitty keyboard protocol is enabled, unless I change false to true in

let action = Action::Write(None, bytes, false);

@imsnif
Copy link
Member

imsnif commented Jun 28, 2024

I appreciate this PR and thank you for it. I hear you that this fixes the issue (and also the issue with the plugin), but I think there might be a different underlying problem (eg. with bracketed paste or the way we serialize keys to the terminal pane when it's operating in a different keyboard mode than the controlling terminal).

I'd rather look more deeply into it and solve the root problem, because what's happening here might just be solving a symptom of it. I fully plan on doing this before the release and will remind everyone that it's better not to use git versions, but rather to use the latest release version.

Thanks for putting this together though.

@towry towry closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot paste into Helix or Neovim or Kakoune when using git version of Zellij
2 participants