-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature: Synchronize text sent to panes #395
New feature: Synchronize text sent to panes #395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I don't think it needs addressing as part of this PR, but I think there are a couple of future extensions - could you create issues for them?
- Controlling which panes in a tab are in sync mode - this could be particularly useful if one of the panes is a plugin, which wouldn't expect to handle the same input as a regular pane.
- Highlighting which panes are in sync mode (with a green border, like the active pane).
I particularly like that you've considered the UI by adding the "Sync" label to the tab.
Thank you, this looks great! |
65e0d20
to
f6df6e9
Compare
So far I don't replicate the text on plugin panes, only to regular panes. How do you imagine the UI for selecting which panes are in sync? I think being able to sync all panes at once is a nice feature and should also be a choice.
|
I have updated the code to reflect this change. Thank you for bringing it up. |
Hey @dantepippi! This is a super sick change that's got great code and adds a great feature! Thanks for fixing the merge conflicts! I'll merge this now and add it to the changelog for you 🙂 Thanks for the awesome PR! |
Creating a new keybinding "s" on the Pane mode. When sync is enabled text will be sent to all terminals on the current tab.
Closes #302