-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Detachable/Persistent sessions #531
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r ClientToServerMsg
imsnif
reviewed
May 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kunalmohan - this looks great and I'm quite excited to say I have virtually no comments.
I left just a really minor few clarification requests on parts that weren't super clear to me, and otherwise two usability things:
- I think we should make the
Sessions
shortcut beCtrl
+i
. Otherwise people might confuse it with tmux :) - Let's put the session shortcut before the Quit in the bar - I think it's good for consistency that quit be the last
- There's a small bug where if you reduce the width of the Zellij window, the shortcut of
Session
becomes<b>sess
. This is unavoidable now that we start having shortcuts where the shortcut letter doesn't match the first letter of the mode name. So I think the best thing would be to remove this behaviour completely from the status bar. If you have time to do this quickly as part of this PR, that would be grand. Otherwise we can leave this bug inside and do it another time - as you wish.
When you feel this is ready, go ahead and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the basic implementation of detachable/persistent sessions.
This PR adds two commands-
attach or a
andlist-sessions or ls
and a new input mode-Session
mode.Ctrl + b
and then detach the session usingd
. Suggestions for better keybindings are most welcome.zellij attach <session_name>
orzellij a <session_name>
. If the session is attached to another client, zellij exits with a message. To force connect, users can add a--force (-f)
flag-zellij a <session_name> -f
. Note: this will disconnect the session from the existing client and connect to this new client.zellij list-sessions
orzellij ls
command. If called from within a zellij session, the output will display(current)
alongside the current session name.Users can now specify names for their session using
--session
or-s
flag. This will create a new session with the given name. If a session with the name already exists, zellij exits with a message.TBD (maybe in a separate PR):