fix unexpected pane closing issue with nushell #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nushell doesn't create a new process group when spawnning a process, so all processes including the ones spwanned by us are in the same foreground group. So if kernel will send signal to every member of this group. This patch fixes this issue by creating a new foreground process group when spawnning a new terminal pane. Fix zellij-org#615 Signed-off-by: Tw <tw19881113@gmail.com>
|
Hey, great work on this! I added a comment to make the unsafe part a little clearer. Thanks! |
|
You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nushell doesn't create a new process group when spawning a process,
so all processes including the ones spawned by us are in the same
foreground group. So the kernel will send signal to every member of this
group.
This patch fixes this issue by creating a new foreground process group
when spawnning a new terminal pane.
Fix #615
Signed-off-by: Tw tw19881113@gmail.com