-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Half-page scroll actions #813
Merged
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
7264d78
Half-page scroll actions #794
oromate 42b6664
fix(performance): do not hang when resizing large line wraps (#814)
imsnif 2ac1454
docs(changelog): scroll fix
imsnif 6d47d36
fix(compatibility): home and end key fix (#815)
imsnif bbf88c6
docs(changelog): home end key fix
imsnif 03e62eb
docs(changelog): fix link
imsnif f902f3e
fix(typo): Correct typo from `occured` to `occurred` (#821)
ken-matsui 954b432
docs(changelog): fix a typo
a-kenji b61489c
fix(docs): fix wrong arguments for `cargo make run` given in CONTRIBU…
ken-matsui 0cfc563
docs(changelog): update `cargo-make` for `v0.35.3`
a-kenji f04a7a4
fix(warning): Fix an unused import warning of std::fs on macos (#820)
ken-matsui 13f3e74
docs(changelog): fix unused import on darwin
a-kenji d2b8129
add: `WriteChars` action (#825)
a-kenji c3e361d
docs(changelog): Add `WriteChars` action
a-kenji 5e720b0
fix(docs): Fix a typo and some grammatical errors in bug_report.md (#…
ken-matsui c39c27c
docs(changelog): fix typo bug_report template
a-kenji 35c566f
add: `rust-version` (msrv) field to `Cargo.toml` (#828)
a-kenji 043a3cf
docs(changelog): add `rust-version` to `Cargo.toml`
a-kenji a14a2f6
fix(unix): forkpty => openpty (#830)
imsnif 7e9dc40
docs(changelog): forkpty => openpty
imsnif 070de7a
Fix: move `colors_transform` to `colorsys` (#832)
a-kenji 2904c04
docs(changelog): `colors_transform` to `colorsys`
a-kenji 9ea3dc0
feat(ui): add right-click support to plugins
tw4452852 b37b9e8
chore(docs): update changelog
TheLostLambda a83a8b9
chore(warnings): remove unused imports (#833)
a-kenji a3bf369
Merge branch 'half-page-scroll' of https://github.com/oromate/zellij …
imsnif 3a92ae1
rename var sroll_rows and review snapshots
oromate 5268e13
Merge branch 'half-page-scroll' of https://github.com/oromate/zellij …
imsnif e922f6f
style(fmt): make rustfmt happy
imsnif File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be
scroll_rows
, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! But to be fair this is also a mistake in the other methods this was copied from. If you'd like to fix this @oromate that would be cool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can fix this. Do you think it makes sense for me to also correct the variable name in the other method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be great, thanks! There are a few of those.