-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide the zellij version to plugins #894
Conversation
I did some research on this feature. For some reason I changed the implementation direction.
So I made a pluginAPI that simply outputs the zellij version. The plugin only needs to call the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would like to have a 2nd pair of eyes here.
I think we could improve the code here a little, let me experiment for a moment! |
Otherwise things look stellar! Thanks for doing this @jaeheonji ! |
* delete unnecessary function
@TheLostLambda Thanks for reviewing! I applied the part you suggested :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
resolves #888