Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IMDb Search Requests #1

Closed
zembrodt opened this issue Nov 18, 2019 · 0 comments
Closed

Add IMDb Search Requests #1

zembrodt opened this issue Nov 18, 2019 · 0 comments
Assignees
@zembrodt
Labels
enhancement New feature or request

Comments

@zembrodt
Copy link
Owner

Add the ability to search IMDb with keywords.

IMDb's search works by sending a GET request to the server (for example: https://v2.sg.media-imdb.com/suggestion/r/robert.json) and receives a JSON response with the results to populate.

Use this JSON response to create a SearchResult Python object containing the ID, and potentially other details, of each result. May need to exclude certain results such as videos or trailers.

Results we care about should only be titles (tt) and people (nm).
@zembrodt zembrodt added the enhancement New feature or request label Nov 18, 2019
@zembrodt zembrodt self-assigned this Nov 18, 2019
zembrodt added a commit that referenced this issue Nov 25, 2019
@zembrodt
#1 Added utils function trim_name
cb147fc
zembrodt added a commit that referenced this issue Nov 25, 2019
@zembrodt
#1 Added new search result objects
5ea77fa
zembrodt added a commit that referenced this issue Nov 25, 2019
@zembrodt
#1 Added get_search_results function to PyMDbScraper
e71dd71
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zembrodt zembrodt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zembrodt