Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Generator Methods to Also Return Dictionaries #4

Closed
zembrodt opened this issue Nov 19, 2019 · 2 comments
Closed

Modify Generator Methods to Also Return Dictionaries #4

zembrodt opened this issue Nov 19, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@zembrodt
Copy link
Owner

Modify certain generator methods, potentially for both PyMDbParser and PyMDbScraper, that return a dictionary of objects rather than a generator. Example would be get_full_credits returning a dictionary where each key is a unique job title and the values are an array of Credit objects.

@zembrodt zembrodt self-assigned this Nov 19, 2019
@zembrodt zembrodt added the enhancement New feature or request label Nov 19, 2019
@zembrodt
Copy link
Owner Author

Somewhat of an overhaul of every method in both the parser and scraper, should be left for a 0.X.0 update.

@zembrodt
Copy link
Owner Author

This should actually be only done for scraper methods as even the largest titles won't return an extremely large list/dictionary to hold in memory. The parser however parses objects from every title/person stored by IMDb so this would be inefficient to completely store in memory.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant