Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default value #117 and #118 #119

Merged
merged 4 commits into from
Jun 16, 2016
Merged

Fix default value #117 and #118 #119

merged 4 commits into from
Jun 16, 2016

Conversation

glutentag
Copy link
Contributor

Here is my proposition of fix for #117 and #118.

2 remarks:

  • I used typeof fieldElement === 'object' && 'default' in fieldElement which might be clearer if using _.has(fieldElement, 'default') but I didn't want to impose lodash
  • Default value is used if value is null or undefined, I don't know if it is your expected behaviour

@coveralls
Copy link

coveralls commented Jun 16, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 528021c on glutentag:fix_default_value into cc5282b on zemirco:master.

@knownasilya knownasilya merged commit 841b685 into zemirco:master Jun 16, 2016
@knownasilya
Copy link
Collaborator

Thanks!

knownasilya pushed a commit that referenced this pull request Jun 16, 2016
v3.4.3
afce53c 
- Update dependencies, see #116, thanks to @havenchyk
- Fix defaults not always set, see #119, thanks to @glutentag
- Add dependencies badge
@knownasilya
Copy link
Collaborator

Published as 3.4.3

@glutentag glutentag deleted the fix_default_value branch June 21, 2016 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glutentag @coveralls @knownasilya