Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for flattening arrays and change transforms arguments to … #432

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Add support for flattening arrays and change transforms arguments to … #432

merged 1 commit into from
Oct 19, 2019

Conversation

juanjoDiaz
Copy link
Collaborator

…an object.

Closes #401

In the future, I might enhance the flatten transform a bit more so you can specify the specific fields that you want to flatten (as in unwind).

@juanjoDiaz
Copy link
Collaborator Author

@knownasilya can you run the tests for this branch locally and give me some hint of what's going on?

All the tests pass just fine on my machine 😕

@knownasilya
Copy link
Collaborator

knownasilya commented Oct 18, 2019

I get one failure
Screen Shot 2019-10-18 at 10 31 26 AM

I'm on node 11.10.0

@coveralls
Copy link

coveralls commented Oct 19, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling f271275 on juanjoDiaz:improve_built_in_transforms into fae7166 on zemirco:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.752% when pulling c359cb3 on juanjoDiaz:improve_built_in_transforms into fae7166 on zemirco:master.

@juanjoDiaz
Copy link
Collaborator Author

All good now!
It was some weird old dependency in node_modules

@knownasilya knownasilya merged commit 916e448 into zemirco:master Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatten arrays
3 participants