Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump motion to 11.15.0 for react 19 compat #405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alcpereira
Copy link
Contributor

@alcpereira alcpereira commented Jan 5, 2025

Description

Following React 19 bump, there was a warning regarding Motion's peer dependency (18 only).
Motion now supports React 19, this PR aims to bump to the latest version that includes this support and removes this warning.

 WARN  Issues with peer dependencies found
.
└─┬ motion 11.13.5
  ├── ✕ unmet peer react@^18.0.0: found 19.0.0
  └── ✕ unmet peer react-dom@^18.0.0: found 19.0.0

Note for reviewers

  • pnpm-lock.yaml includes a lot more changes unrelated to this bump, this is most likely related to previous bumps that did not commit this file.
  • Peer dep was introduced in 11.13.6 but I bumped directly to latest version (see CHANGELOG)

@NOCanoa NOCanoa added the enhancement New feature or request label Jan 11, 2025
@mauro-balades
Copy link
Member

There's git conflicts in the package-lock @alcpereira, could you please fix it?

@alcpereira
Copy link
Contributor Author

@mauro-balades I've updated it.
Note that a the pnpm-lock has a lot of changes due to the current formatting, it might be worth to configure Prettier to not format this file as it should be handled solely by the package manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants