-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tp2squadmate #24
Conversation
…d as Test and restyled later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to use this action while a team mate is in the respawn menu, produces a script error.
I had forgotten a null check for dead players. Added now. Although if all squadmembers are dead now, so the list is empty, it just shows the empty list. Maybe would be better if empty list, to close the list and show hint to GM that there is no valid squadmembers to TP to? |
I would say either way is fine. |
I think I am just going to leave it be an empty menu for now. Only in rare cases it would happen. The other approach would require making some hint helper, to send localized hints to specific players over Rpl. As the context-action is run with |
4940928
to
5a7a4b8
Compare
86af2a4
to
7446d8b
Compare
...s/Game/ODIN/Editor/Containers/Actions/ContextActions/ODIN_TeleportToSquadmateContextAction.c
Show resolved
Hide resolved
...s/Game/ODIN/Editor/Containers/Actions/ContextActions/ODIN_TeleportToSquadmateContextAction.c
Outdated
Show resolved
Hide resolved
...s/Game/ODIN/Editor/Containers/Actions/ContextActions/ODIN_TeleportToSquadmateContextAction.c
Outdated
Show resolved
Hide resolved
...s/Game/ODIN/Editor/Containers/Actions/ContextActions/ODIN_TeleportToSquadmateContextAction.c
Outdated
Show resolved
Hide resolved
...s/Game/ODIN/Editor/Containers/Actions/ContextActions/ODIN_TeleportToSquadmateContextAction.c
Outdated
Show resolved
Hide resolved
…adisu to static variable
Pull request adds the Teleport To Squadmate feature together with some helpers used in this feature:
Teleport to squadmate allow GM to right-click a player and select what squadmate to teleport the player to. Makes it easy to move a lost or respawned player back to his squad.
This feature does not work on AI or AI groups as it would require specific handling and at this point, AI can't be in groups with players anyway.