Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ambient flyby modules #49

Open
wants to merge 51 commits into
base: master
Choose a base branch
from
Open

Add ambient flyby modules #49

wants to merge 51 commits into from
+1,813 −225

Conversation

Kexanone
Copy link
Member

@Kexanone Kexanone commented Jul 31, 2024 •
edited
Loading

When merged this pull request will:

  • Add ambient flyby modules for UH-1H and Mi-8MT

@Kexanone Kexanone added the feature Adds a new feature label Jul 31, 2024
@Kexanone Kexanone changed the title Add Ambient Flyby Modules Add ambient flyby modules Jul 31, 2024
@Kexanone
Update stringtable
93c14ed
@Kexanone
Rearrange module base methods and add init done bool
295efdd
@Kexanone
Merge branch 'feature/simple-module-framework' into feature/ambient-f…
ba88b09 
…lyby
@Kexanone
Make sure init done only runs on authority
d32f351
@Kexanone
Update meta file
4bb8843
@Kexanone
Introduce module placing actions
e64fe42
@Kexanone
Make module not streamable by default
e8fa9c0
@Kexanone
Change default image for module
6699def
@Kexanone
Add placing actions for opening editor browser
3ac3c4e
@Kexanone
Require entity in world placing action
3315531
@Kexanone
Sleep placing action
61c6220
@Kexanone
Spawn default occupants placing action
8df6345
@Kexanone
Force writing module attributes
5618315
@Kexanone
Proper prefix for placing actions
20247f8
@Kexanone
Proper prefix modules
10354f0
@Kexanone
Prefix EditableModuleComponent
2f31bf8
@Kexanone
Rename placing actions to init actions
79511fd
@Kexanone
Add on placing canceled event
8b956f2
@Kexanone
Merge branch 'feature/simple-module-framework' into feature/ambient-f…
83d423e 
…lyby
@Kexanone
Fix localization and prefab prefixes
257a5e4
@Kexanone
Fix editable component
70bc9af
@Kexanone
Do not delete immediately
b433f32
@Kexanone
Update meta
b3ca449
@Kexanone
Create separate config for module attributes
9e214f3
@Kexanone
Merge branch 'feature/simple-module-framework' into feature/ambient-f…
e3e41cc 
…lyby
@Kexanone Kexanone added this to the 1.3.0 milestone Aug 3, 2024
Crowdedlight
Crowdedlight reviewed Aug 4, 2024
View reviewed changes
Copy link
Contributor

@Crowdedlight Crowdedlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. A few nitpicks or questions.

I couldn't really fully follow if the .conf files are set correctly when seeing it here in text-form, but I assume they are correct.

I have not had time to run in in workbench.

addons/GME/Language/GME_localization.st Show resolved Hide resolved
addons/GME/Language/GME_localization.st Outdated Show resolved Hide resolved
addons/GME/Prefabs/Vehicles/Helicopters/Mi8MT/GME_Mi8MT_ambient.et Show resolved Hide resolved
addons/GME/Scripts/Game/GME/Editor/Modules/GME_Modules_AmbientFlyby.c Outdated Show resolved Hide resolved
addons/GME/Scripts/Game/GME/Editor/Modules/GME_Modules_AmbientFlyby.c Outdated Show resolved Hide resolved
Base automatically changed from feature/simple-module-framework to master August 4, 2024 16:53
@Kexanone Kexanone mentioned this pull request Aug 27, 2024
Closed
@Kexanone Kexanone changed the base branch from master to revise/module-framework October 20, 2024 11:45
Base automatically changed from revise/module-framework to master October 20, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crowdedlight Crowdedlight Awaiting requested review from Crowdedlight

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature Adds a new feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Kexanone @Crowdedlight