Toggle ACE captive and surrender via context menu #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharis001
reviewed
Jan 11, 2020
|
Alrighty, removed ace_zeus dependency and made the other requested changes |
|
👍Looks good to me. Should merge after #286 I think, will be easier to deal with any conflicts or make small adjustments. |
|
I did some cleanup for the context menu changes, added an icon to the main node, added the "Captives" string (would cause an RPT error if ACE was not loaded), and moved the |
mharis001
approved these changes
Feb 20, 2020
CreepPork
approved these changes
Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
I decided to use the strings and icons from ace_captives and ace_zeus since it's currently dependent on the former and I doubt many would remove the latter. Other alternative I guess is copying over the strings and possibly the icons if ACE team is fine with that.