Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock malaria-infected civs #384

Closed
wants to merge 5 commits into from
Closed

Unlock malaria-infected civs #384

wants to merge 5 commits into from

Conversation

Kexanone
Copy link
Member

Preface:

The Old Man update introduced malaria-infected civilians, however these classes are currently not visible in Eden and Zeus. The way they work is that they change the wound textures of the base civilian classes, which means that the infection is only visible when the unit is injured.

When merged this pull request will:

  • Unlock malaria-infected civilian classes.
  • Set the proper identities for malaria-infected civilian (fixes the faces).
  • Add damage to malaria-infected civilian to make the infection visible.

@Kexanone Kexanone added the feature Adds a new feature label May 21, 2020
@Kexanone Kexanone self-assigned this May 21, 2020
@CreepPork CreepPork added this to the 1.8.0 milestone May 21, 2020
Kexanone and others added 2 commits May 21, 2020 16:54
Co-authored-by: Ralfs Garkaklis <ralfs@garkaklis.com>
@Kexanone Kexanone mentioned this pull request May 22, 2020
7 tasks
addons/characters/CfgVehicles.hpp Outdated Show resolved Hide resolved
addons/characters/CfgVehicles.hpp Outdated Show resolved Hide resolved
addons/characters/config.cpp Outdated Show resolved Hide resolved
addons/characters/script_component.hpp Outdated Show resolved Hide resolved
@@ -0,0 +1,5 @@
class CfgEditorSubcategories {
class EdSubcat_Personnel_Sick {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe GVAR but I am not sure on this. Sticking to the class naming convention for CfgEditorSubcategories is fine as well.

Copy link
Member

@CreepPork CreepPork May 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m as well not sure on this but maybe sometime in the future some other mod would create such a class too and we’d have a conflict. So perhaps using the GVAR might be better and it really doesn’t change anything that much.

You could just wrap it in a GVAR and that’d be fine.

@bux
Copy link
Contributor

bux commented May 22, 2020

Is Zen the right mod for this?
CBA or ACE would make more sense, wouldn't it?

@Kexanone
Copy link
Member Author

It's pretty much a modification the get them working in the editor. These classes can already be used without any config modifications in scripts. That's how Old Man does it. However, we could consider moving it to CBA.

@CreepPork
Copy link
Member

@bux

It could be debated that the unlocking of music classes for Zeus could also be moved to CBA, but at the same time it could be left in as it is regarding the Zeus.

@neilzar
Copy link
Contributor

neilzar commented May 26, 2020

I would say this is better in CBA. It also applies to the editor, so already goes beyond Zeus. It also doesn't require any ZEN functions so there is no real reason to prefer it here over CBA. I say CBA over ACE because music is already unlocked in CBA as well.

@bux
Copy link
Contributor

bux commented May 26, 2020

@CreepPork true
Move it to CBA then 👍 😄

@mharis001 mharis001 removed this from the 1.8.0 milestone May 27, 2020
@Kexanone
Copy link
Member Author

Closed in favor of CBATeam/CBA_A3#1344

@Kexanone Kexanone closed this May 27, 2020
@mharis001 mharis001 deleted the unlock-malaria-civs branch May 29, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants