-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unlock malaria-infected civs #384
Conversation
Co-authored-by: Ralfs Garkaklis <ralfs@garkaklis.com>
@@ -0,0 +1,5 @@ | |||
class CfgEditorSubcategories { | |||
class EdSubcat_Personnel_Sick { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe GVAR
but I am not sure on this. Sticking to the class naming convention for CfgEditorSubcategories
is fine as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m as well not sure on this but maybe sometime in the future some other mod would create such a class too and we’d have a conflict. So perhaps using the GVAR might be better and it really doesn’t change anything that much.
You could just wrap it in a GVAR and that’d be fine.
Is Zen the right mod for this? |
It's pretty much a modification the get them working in the editor. These classes can already be used without any config modifications in scripts. That's how Old Man does it. However, we could consider moving it to CBA. |
It could be debated that the unlocking of music classes for Zeus could also be moved to CBA, but at the same time it could be left in as it is regarding the Zeus. |
I would say this is better in CBA. It also applies to the editor, so already goes beyond Zeus. It also doesn't require any ZEN functions so there is no real reason to prefer it here over CBA. I say CBA over ACE because music is already unlocked in CBA as well. |
@CreepPork true |
Closed in favor of CBATeam/CBA_A3#1344 |
Preface:
The Old Man update introduced malaria-infected civilians, however these classes are currently not visible in Eden and Zeus. The way they work is that they change the wound textures of the base civilian classes, which means that the infection is only visible when the unit is injured.
When merged this pull request will: