Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opening context menu by right clicking when AI are selected #481

Merged
merged 6 commits into from
Mar 30, 2021

Conversation

mharis001
Copy link
Member

@mharis001 mharis001 commented Oct 3, 2020

When merged this pull request will:

  • Allow opening context menu by right clicking when waypoint placement would normally occur due to selected AI and/or waypoints
    • Enabled through "Override Waypoint Placement" setting (default: false)
    • Can use SHIFT key to still place waypoints when enabled
  • Requires new tvSelection and tvSetSelected script commands available on dev branch

@mharis001 mharis001 added the enhancement Improves an existing feature label Oct 3, 2020
@mharis001 mharis001 added this to the Backlog milestone Oct 3, 2020
@mharis001 mharis001 marked this pull request as ready for review February 26, 2021 16:44
@mharis001 mharis001 modified the milestones: Backlog, 1.11.0 Feb 26, 2021
@CreepPork CreepPork added the 2.02 Arma 3 2.02 label Mar 4, 2021
@CreepPork CreepPork requested a review from neilzar March 4, 2021 08:42
Copy link
Contributor

@neilzar neilzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the context menu is open with a unit or group selected and I right-click somewhere it will place a waypoint, I expected a new context menu to be opened or the current to be closed. It doesn't place a waypoint every time, it seems to be acting quite random when it does and when it opens the context menu in a different place.

@neilzar
Copy link
Contributor

neilzar commented Mar 5, 2021

The previously mentioned issue is also a thing without selecting anything. Right-clicking will randomly not open the context menu and move the camera around. I think this may be an issue with incorrectly detecting the right click.

@mharis001
Copy link
Member Author

mharis001 commented Mar 5, 2021

Can't reproduce. Moving the camera part is intentional since the context menu should not be opened if camera panning was started between RMB down and up events.

Copy link
Contributor

@neilzar neilzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is just down to the tiniest movement being detected between button-down and up.

@neilzar neilzar removed the 2.02 Arma 3 2.02 label Mar 6, 2021
@mharis001 mharis001 merged commit 4cef561 into master Mar 30, 2021
@mharis001 mharis001 deleted the context-menu-right-click branch March 30, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants