Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve object serialization by saving vector dir and up #499

Merged
merged 3 commits into from
Jan 23, 2021
Merged

Improve object serialization by saving vector dir and up #499

merged 3 commits into from
Jan 23, 2021

Conversation

Kexanone
Copy link
Member

@Kexanone Kexanone commented Jan 8, 2021 •
edited
Loading

@Kexanone Kexanone added the bug fix Fixes a bug label Jan 8, 2021
@Kexanone Kexanone added this to the Ongoing milestone Jan 8, 2021
@Kexanone Kexanone self-assigned this Jan 8, 2021
@Kexanone Kexanone changed the title Revise Serialization Serialize vector dir and up Jan 23, 2021
@Kexanone Kexanone marked this pull request as ready for review January 23, 2021 16:54
neilzar
neilzar approved these changes Jan 23, 2021
View reviewed changes
Copy link
Contributor

@neilzar neilzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth adding a deprecation warning

@Kexanone
Copy link
Member Author

Maybe worth adding a deprecation warning

No, need. We just accept both formats. It would be rather annoying if you get a deprecation warning for all your compositions.

@mharis001 mharis001 changed the title Serialize vector dir and up Improve object serialization by saving vector dir and up Jan 23, 2021
@Kexanone Kexanone merged commit 6fa3460 into master Jan 23, 2021
@Kexanone Kexanone deleted the revise-serialization branch January 23, 2021 22:25
@Kexanone Kexanone modified the milestones: Ongoing, 1.10.0 Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 approved these changes

@neilzar neilzar neilzar approved these changes

@ampersand38 ampersand38 Awaiting requested review from ampersand38

Assignees

@Kexanone Kexanone

Labels
bug fix Fixes a bug
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

Compositions not saving pitch (X) and roll (Y) of entities
3 participants
@Kexanone @neilzar @mharis001