Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert compositions to hashes #552

Merged
merged 16 commits into from
Sep 3, 2021
Merged

Convert compositions to hashes #552

merged 16 commits into from
Sep 3, 2021

Conversation

neilzar
Copy link
Contributor

@neilzar neilzar commented Feb 13, 2021

When merged this pull request will:

  • Title
  • Should improve performance slightly as findif is no longer needed.

@neilzar neilzar added enhancement Improves an existing feature 2.02 Arma 3 2.02 labels Feb 13, 2021
@neilzar neilzar added this to the Backlog milestone Feb 13, 2021
@neilzar neilzar modified the milestones: Backlog, 1.11.0 Feb 23, 2021
@mharis001
Copy link
Member

Will check if tree additions are still processed correctly.

mharis001
mharis001 reviewed Jun 7, 2021
View reviewed changes
addons/compositions/XEH_preInit.sqf Outdated Show resolved Hide resolved
addons/compositions/script_component.hpp Show resolved Hide resolved
addons/compositions/XEH_preInit.sqf Outdated Show resolved Hide resolved
addons/compositions/functions/fnc_openDisplay.sqf Outdated Show resolved Hide resolved
addons/compositions/functions/fnc_openDisplay.sqf Outdated Show resolved Hide resolved
@mharis001
Copy link
Member

Doesn't correctly delete empty category hashes. I think this likely just needs to call removeFromTree with _deleteFromData as true in edit mode.

@mharis001 mharis001 removed this from the 1.11.0 milestone Jun 16, 2021
@mharis001 mharis001 added this to the 1.12.0 milestone Jun 16, 2021
@neilzar neilzar requested a review from mharis001 July 24, 2021 14:28
mharis001
mharis001 reviewed Sep 2, 2021
View reviewed changes
Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected now. Just some style/cleanup suggestions.

addons/compositions/functions/fnc_openDisplay.sqf Outdated Show resolved Hide resolved
addons/compositions/functions/fnc_openDisplay.sqf Outdated Show resolved Hide resolved
addons/compositions/functions/fnc_removeFromTree.sqf Show resolved Hide resolved
addons/compositions/functions/fnc_initDisplayCurator.sqf Show resolved Hide resolved
addons/compositions/functions/fnc_removeFromTree.sqf Outdated Show resolved Hide resolved
addons/compositions/functions/fnc_openDisplay.sqf Outdated Show resolved Hide resolved
@neilzar neilzar merged commit a22ac29 into master Sep 3, 2021
@mharis001 mharis001 deleted the hash-compositions branch September 3, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 approved these changes

@CreepPork CreepPork CreepPork approved these changes

Assignees
No one assigned
Labels
2.02 Arma 3 2.02 enhancement Improves an existing feature
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neilzar @mharis001 @CreepPork