-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common - Filter for ACRE radio IDs when serializing objects #640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Looks fine, but doesn't fix the issue yet for exporting mission SQF.
I guess your approach could also be applied to https://github.com/zen-mod/ZEN/blob/master/addons/common/functions/fnc_exportMissionSQF.sqf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we go with this approach then I would want to add TFAR support (doesn't need to be in this PR). We could also try and hold out for the extended loadout framework proposed for CBA but not sure when (or if) that will be merged.
Overall, seems okay, but maybe we should have our own get/set loadout functions in common
instead of duplicating code.
@mharis001 Also I'm not really sure if the |
Co-authored-by: Kex <kexanone@gmail.com>
Co-authored-by: Kex <kexanone@gmail.com>
Did it so its not just getUnitLoadout wrapped in a macro. Not necessary but helps maintain syntax highlighting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just some cleanup.
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
When merged this pull request will:
postInit.sqf
acre_api_fnc_filterUnitLoadout
to remove replace ACRE radio IDs with base radios