Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Filter for ACRE radio IDs when serializing objects #640

Merged
merged 15 commits into from
Feb 9, 2022

Conversation

mjc4wilton
Copy link
Contributor

When merged this pull request will:

@mharis001 mharis001 added the enhancement Improves an existing feature label Oct 19, 2021
Copy link
Member

@Kexanone Kexanone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks fine, but doesn't fix the issue yet for exporting mission SQF.
I guess your approach could also be applied to https://github.com/zen-mod/ZEN/blob/master/addons/common/functions/fnc_exportMissionSQF.sqf.

Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go with this approach then I would want to add TFAR support (doesn't need to be in this PR). We could also try and hold out for the extended loadout framework proposed for CBA but not sure when (or if) that will be merged.

Overall, seems okay, but maybe we should have our own get/set loadout functions in common instead of duplicating code.

addons/common/XEH_postInit.sqf Outdated Show resolved Hide resolved
addons/context_actions/CfgContext.hpp Outdated Show resolved Hide resolved
@Kexanone
Copy link
Member

@mharis001
When do we prefer event handlers over functions?

Also I'm not really sure if the safe postfix is really necessary.

mjc4wilton and others added 3 commits November 29, 2021 12:01
Co-authored-by: Kex <kexanone@gmail.com>
Co-authored-by: Kex <kexanone@gmail.com>
@mjc4wilton
Copy link
Contributor Author

Also I'm not really sure if the safe postfix is really necessary.

Did it so its not just getUnitLoadout wrapped in a macro. Not necessary but helps maintain syntax highlighting

Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some cleanup.

addons/common/XEH_PREP.hpp Outdated Show resolved Hide resolved
addons/common/functions/fnc_getUnitLoadoutSafe.sqf Outdated Show resolved Hide resolved
addons/common/functions/fnc_getUnitLoadoutSafe.sqf Outdated Show resolved Hide resolved
addons/common/functions/fnc_getUnitLoadoutSafe.sqf Outdated Show resolved Hide resolved
addons/context_actions/CfgContext.hpp Outdated Show resolved Hide resolved
addons/common/functions/fnc_getUnitLoadoutSafe.sqf Outdated Show resolved Hide resolved
mjc4wilton and others added 6 commits January 26, 2022 14:41
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
@mharis001 mharis001 added this to the 1.13.0 milestone Jan 27, 2022
@mharis001 mharis001 merged commit 36ed484 into zen-mod:master Feb 9, 2022
@mharis001 mharis001 modified the milestones: 1.13.0, 1.12.2 Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep copy/paste will include ACRE radio ID's
3 participants