-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Advanced Rappelling compatibility #700
Conversation
|
Maybe these should be two separate waypoints (Fastrope and Advanced Rappel) because the mods could be run together. We could add conditions to waypoints so that they only show if the required mods are loaded. |
Sounds like a good alternative approach. Would you propose the AR waypoint in a compat. or part of the main addon? If I remember correctly we decided against having anything but ACE as soft dependency in the main addon, that's why I went the compat. route in the first place. |
Yeah, I think we can revisit that decision for some other big mods. I think both a new component (separation of features/responsibilities) or just in the |
I separated out the waypoints into "Fastrope" and "Rappel" and reworked how reinforcements handles the different insertion methods for air vehicles. I think we should keep the Advanced Rapelling compatibility as a separate optional component. |
@Kexanone, I think this is good to go. Please look over my changes and merge when ready. |
Looks good to me, but still needs to be tested if you haven't already. |
I did the usual testing, and everything seemed okay. I think we are good to merge. |
When merged this pull request will: