Conditionally Load Compats #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharis001
approved these changes
Sep 9, 2023
|
One disadvantage is that this approach won't work when Advanced Rappelling is only present as a server side mod, but I would say that is a small price to pay for getting rid of compats. |
|
Because the Advanced Rappelling compat only adds the waypoint and the waypoint's condition will prevent it from being shown when the mod is not loaded, we do not need to use |
mharis001
approved these changes
Oct 2, 2023
|
lgtm, just needs to be tested. I can have a look on my test server when I got time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
skipWhenMissingDependenciesto conditionally load compats fromrequiredAddonsrequiredAddon