Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Supply Cargo Attributes #753

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Add Supply Cargo Attributes #753

merged 6 commits into from
Nov 17, 2023

Conversation

ampersand38
Copy link
Member

When merged this pull request will:

  • Add attributes for supply vehicles to adjust their supply cargo

@ampersand38 ampersand38 added the feature Adds a new feature label Oct 11, 2023
mharis001
mharis001 reviewed Oct 20, 2023
View reviewed changes
addons/attributes/stringtable.xml Outdated
<English>Repair Cargo</English>
</Key>
<Key ID="STR_ZEN_Attributes_SupportCargo_Tooltip">
<English>Cargo to supply to other vehicles.</English>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tooltip necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can certainly be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds a bit too generic. I guess we can either remove or add more specific tooltips.

@mharis001 mharis001 added this to the 1.15.0 milestone Oct 20, 2023
@mharis001
Copy link
Member

Also, should add settings to enable/disable these like other attributes.

mharis001
mharis001 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@ampersand38 ampersand38 merged commit 07031ba into zen-mod:master Nov 17, 2023
2 checks passed
@ampersand38 ampersand38 deleted the attributes-supplies branch November 17, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 approved these changes

Assignees
No one assigned
Labels
feature Adds a new feature
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ampersand38 @mharis001