Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/application parsing #53

Merged
merged 4 commits into from
Nov 14, 2018
Merged

Improve/application parsing #53

merged 4 commits into from
Nov 14, 2018

Conversation

zenangst
Copy link
Owner

@zenangst zenangst commented Nov 14, 2018

  • Removes special case for adding Finder to the list of applications
  • Improves how applications are filtered out from the list of applications

Applications that don't show up on the list are excluded because of the following reasons.

  • Their application name includes any of the excluded keywords
let excludeKeywords = [
  "handler", "agent", "migration",
  "problem", "setup", "uiserver",
  "install", "system image", "escrow"]
  • The application is lacking an icon
  • Uses Electron

@JayBrown
Copy link
Collaborator

Question: is it wise to exclude applications without icons? I'm wondering if it's possible to have an application without an icon that's still dark-mode compatible; case in point would be SlowQuitApps: https://github.com/dteoh/SlowQuitApps … or does that exclusion only apply to CoreServices?

@zenangst
Copy link
Owner Author

Right now it covers all applications, not just the ones found in CoreServices.
Maybe scoping the filter to that folder would be a good improvement. I'm gonna try that

…Library/CoreServices"

Add escrow to list of excluded keywords
@zenangst
Copy link
Owner Author

@JayBrown refactored the code now, I think it should be good to go.

@zenangst zenangst merged commit f2b16e0 into master Nov 14, 2018
@zenangst zenangst deleted the improve/application-parsing branch November 14, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants