Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing when selecting "Editor" #3

Closed
Allesanddro opened this issue Jul 19, 2020 · 14 comments
Closed

Crashing when selecting "Editor" #3

Allesanddro opened this issue Jul 19, 2020 · 14 comments
Assignees
Labels
bug Something isn't working

Comments

@Allesanddro
Copy link

Allesanddro commented Jul 19, 2020

image

report.txt

That should be everything you need ^^

@cengelha cengelha self-assigned this Jul 19, 2020
@cengelha
Copy link
Member

Could it be possible that you manually deleted the "TeleporterEndpoints" entry? That shouldn't happen if it's in there like the game dictates.

@cengelha cengelha added the question Further information is requested label Jul 19, 2020
@Allesanddro
Copy link
Author

Allesanddro commented Jul 19, 2020

well idk i didnt edited that much if i did so is there a way to revert it?

@cengelha
Copy link
Member

Saving again in-game should fix it. Could you attach the JSON of it here (Save to JSON)? Then I can have a look at it.

@Allesanddro
Copy link
Author

Allesanddro commented Jul 20, 2020 via email

@Allesanddro
Copy link
Author

so uh were does the json file gets saved?

@cengelha
Copy link
Member

In the "json" folder in the output path. You can open it diretly from the manager page by clicking the open-folder icon next to the path.

@Allesanddro
Copy link
Author

they r empty
https://pastebin.com/raw/VYbwbC40

@webmaster442
Copy link

I can confirm the issue. Prior to experiencing this I deleted the teleporter and placed a new one on my 1st starting base. Stack trace for exception in my case: System.NullReferenceException

Game version: Latest steam version.

at:  NomNom.ViewModel.EditorDiscoveryViewModel.get_JsonTeleportEndpoints() hely: C:\Users\cenge\source\repos\NomNom\NomNom\ViewModel\EditorDiscoveryViewModel.cs, line: 51
at:  NomNom.ViewModel.EditorDiscoveryViewModel.FillCollection() hely: C:\Users\cenge\source\repos\NomNom\NomNom\ViewModel\EditorDiscoveryViewModel.cs, line: 633
at:  NomNom.ViewModel.EditorDiscoveryViewModel..ctor() hely: C:\Users\cenge\source\repos\NomNom\NomNom\ViewModel\EditorDiscoveryViewModel.cs, line: 621
at:  NomNom.ViewModel.EditorViewModel..ctor() hely: C:\Users\cenge\source\repos\NomNom\NomNom\ViewModel\EditorViewModel.cs, line: 81
at:  NomNom.ViewModel.MainViewModel.NavigateToEditor() hely: C:\Users\cenge\source\repos\NomNom\NomNom\ViewModel\MainViewModel.cs, line: 257
at:  MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
at:  System.Windows.Controls.Primitives.ButtonBase.OnClick()
at:  System.Windows.Controls.Button.OnClick()
at:  System.Windows.Controls.Primitives.ButtonBase.OnMouseLeftButtonUp(MouseButtonEventArgs e)
at:  System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
at:  System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
at:  System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
at:  System.Windows.UIElement.ReRaiseEventAs(DependencyObject sender, RoutedEventArgs args, RoutedEvent newEvent)
at:  System.Windows.UIElement.OnMouseUpThunk(Object sender, MouseButtonEventArgs e)
at:  System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
at:  System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
at:  System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
at:  System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
at:  System.Windows.UIElement.RaiseTrustedEvent(RoutedEventArgs args)
at:  System.Windows.Input.InputManager.ProcessStagingArea()
at:  System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
at:  System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
at:  System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
at:  System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, WindowMessage msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at:  System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at:  MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at:  MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
at:  System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at:  System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

Json output just writes a null to the export.

@cengelha cengelha added bug Something isn't working and removed question Further information is requested labels Jul 21, 2020
@cengelha
Copy link
Member

Alright. Starting with the next version it will be more restrive with this and wont allow such files to load but maybe showing them in the selection marked as invalid in an additional column.
Can any of you attach a save that will trigger this error?

@webmaster442
Copy link

I try to create an other save. After playing a litle bit more & doing some quests my save file appears to be fixed, It's openable again without issues

@cengelha
Copy link
Member

Got it now on one of my own saves. Seems to be indeed a problem when it tries to load the existing but empty list of "TeleportEndpoints" which should only be a problem with a freshly started save when you haven't yet created a base or visited a space station.
It will not be deserialized to an empty list but to "null" and therefore throw this exeption. As I have a save to reproduce it now, I will find a way to fix it.
But the new restrictions will come nonetheless as I already wasn't that happy with the current way.

@cengelha
Copy link
Member

Or not. It was an other error caused by not executed/commented code to trace an other issue... Save is still need

@Allesanddro
Copy link
Author

@cengelha
Copy link
Member

Thanks @Allesanddro! The stack trace was actually a false trace. That ViewModel is just the first one that is loaded and therefore shown...
The actual problem was a false data type for an entry in the file. Hadn't set the "MultiplayerLobbyID" to anything else than the default (0) in my saves but it could also be as seed (text) as in yours. Fixed in the next version. The "null" in the json was the same that caused this exception

Currently working on the restrictions mentioned above and one a good way but will probably still need some days to finish (the next version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants