Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

Bump to rails 7 #82

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Bump to rails 7 #82

merged 4 commits into from
Jan 29, 2024

Conversation

zenspider
Copy link
Contributor

No description provided.

@zenspider zenspider requested a review from a team as a code owner July 20, 2023 21:49
@zenspider zenspider force-pushed the zenspider/rails7 branch 5 times, most recently from 912636b to e8e9192 Compare July 20, 2023 23:05
Copy link

@KJTsanaktsidis KJTsanaktsidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks "failed" in the PR UI but.... that's really a github UI issue. People have been asking for this to be better serviced for a while it seems: https://github.com/orgs/community/discussions/15452

@zenspider
Copy link
Contributor Author

yup yup... as long as the BIG status at the top is green, it is good... the UI is deplorable, but then again, what can you expect?

@zenspider zenspider requested a review from zendesk-jmeade July 20, 2023 23:09
Copy link

@HeyNonster HeyNonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because I think the intent is to get Kasket to bundle with Rails 7 and, at a later point, we'll work on getting the tests passing for the experimental gemfiles.

Copy link
Contributor

@zendesk-jmeade zendesk-jmeade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It pains me to approve this and give kasket another reprieve 😄

.github/workflows/test.yml Outdated Show resolved Hide resolved
gemfiles/common.rb Show resolved Hide resolved
gemfiles/rails5.1.gemfile Outdated Show resolved Hide resolved
@zenspider zenspider requested a review from bquorning January 29, 2024 20:59
@zenspider zenspider merged commit c934754 into main Jan 29, 2024
11 of 12 checks passed
@zenspider zenspider deleted the zenspider/rails7 branch January 29, 2024 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants