Merge pull request #1198 from zendesk/ben/empty_sql_comments

deal with empty SQL comments
zendesk · Jan 25, 2019 · 5637d53 · 5637d53
2 parents fa12fe0 + 07b1145
commit 5637d53
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/main/antlr4/imports/mysql_idents.g4 b/src/main/antlr4/imports/mysql_idents.g4
@@ -46,6 +46,7 @@ SQL_UPGRADE_ENDCOMMENT: '*/' -> skip;
 MAXWELL_ELIDED_PARSE_ISSUE: '/__MAXWELL__/';
 
 SQL_COMMENT: '/*' ~'!' (.)*? '*/' -> skip;
+SQL_EMPTY_COMMENT: '/**/' -> skip;
 
 SQL_LINE_COMMENT: ('#' | '--') (~'\n')* ('\n' | EOF) -> skip;
 

diff --git a/src/test/java/com/zendesk/maxwell/schema/ddl/DDLParserTest.java b/src/test/java/com/zendesk/maxwell/schema/ddl/DDLParserTest.java
@@ -425,6 +425,12 @@ public void testCommentSyntax2() {
 		assertThat(changes.size(), is(1));
 	}
 
+	@Test
+	public void testCommentSyntax3() {
+		List<SchemaChange> changes = parse("/**/ CREATE DATABASE if not exists `foo`");
+		assertThat(changes.size(), is(1));
+	}
+
 	@Test
 	public void testCurrentTimestamp() {
 		List<SchemaChange> changes = parse("CREATE TABLE `foo` ( `id` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP )");