Fix config load for liveness probe #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasch
reviewed
Sep 29, 2023
lib/racecar/ctl.rb
Outdated
| @@ -36,10 +36,14 @@ def liveness_probe(args) | |||
| require "racecar/liveness_probe" | |||
| parse_options!(args) | |||
|
|
|||
| if ENV["RAILS_ENV"] | |||
| if ENV["RAILS_ENV"] && File.exist?("config/racecar.yml") | |||
| Racecar.config.load_file("config/racecar.yml", ENV["RAILS_ENV"]) | |||
There was a problem hiding this comment.
Perhaps we should use this method for loading the config?
There was a problem hiding this comment.
@dasch I've updated it to behave exactly as the cli load them
There was a problem hiding this comment.
I am wondering if loading the config like this (RailsConfigFileLoader) is the right thing here, doesn't that mean the liveness probe will always try to boot the entire Rails app just to check the modified time of a file?
There is the without_rails config option, but what if the consumer needs Rails, then the liveness probe will do all that extra work for nothing.
Some rails apps might chose to not use the racecal.yml file. Let's load known config files if they are present similar to how cli handles them
deepredsky
force-pushed
the
liveness-probe
branch
from
7c1f456 to
2d9222b
Compare
dasch
approved these changes
Oct 4, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some rails apps might chose to not use the racecal.yml file. Let's load known
config files if they are present similar to how cli handles them