Resolve Rails 7.1 logger incompatibility #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubin
force-pushed
the
zh/bugfix/rails71-logger
branch
from
867b293 to
4400f05
Compare
|
Out of curiosity, why was this PR closed ? This fix looks good to me ( it's the same strategy as used on sidekiq ) |
|
The patch here should work, @zubin I m happy to merge this patch unless you found some issue with this change |
No issues, it's been working fine. 👍 |
|
@deepredsky Could you release a new version please? |
|
Oh I see there is 2.10.0.beta2, why not a non-beta version? |
2.10.0 is released now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #356
There don't appear to be any tests which cover this but I've verified that it works locally.