Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "consuming messages with a custom assignment strategy" stable #876

Merged

Conversation

abicky
Copy link
Contributor

@abicky abicky commented Dec 12, 2020

In the example, one consumer sometimes consumers all messages before another consumer joins. As a result, the example is unstable. This PR makes it stable by ensuring all consumers have joined.

@abicky abicky force-pushed the make-custom-assignment-strategy-example-stable branch 3 times, most recently from b280d08 to b5223b2 Compare December 12, 2020 18:12
In the example, one consumer sometimes consumers all messages
before another consumer joins. As a result, the example is
unstable. This commit makes it stable by ensuring all consumers
have joined.
@abicky abicky force-pushed the make-custom-assignment-strategy-example-stable branch from b5223b2 to cda7667 Compare December 12, 2020 18:32
Copy link
Contributor

@dasch dasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo, but otherwise 👍

spec/functional/consumer_group_spec.rb Outdated Show resolved Hide resolved
spec/functional/consumer_group_spec.rb Outdated Show resolved Hide resolved
spec/functional/consumer_group_spec.rb Outdated Show resolved Hide resolved
Co-authored-by: Daniel Schierbeck <dasch@zendesk.com>
@abicky
Copy link
Contributor Author

abicky commented Dec 30, 2020

Thank you for your review! I applied your suggestions in fe7bc77.

@dasch dasch merged commit 49c6194 into zendesk:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants