Handle SyncGroup responses with a non-zero error and no assignments

[BrentWheeldon]

When the error code is non-zero there isn't necessarily (ever?) an assignment. Currently the decoder raises a TypeError ("no implicit conversion of nil into String") - this updates the logic to only try to decode the assignment if there are any bytes.

[dasch]

Shouldn't we raise an error in that scenario?

[BrentWheeldon]

@dasch the appropriate error is raised by Protocol.handle_error, at least in the situation I ran into (because of code in ConsumerGroup#synchronize). I'm not overly familiar with the internals of this gem but it seems like the error raising isn't generally happening in the response objects, but rather in the code that's making the request and using the response (like ConsumerGroup#synchronize in the situation I ran into).

Having said that, definitely happy to make this raise if you think that's appropriate. Would calling Protocol.handle_response in the .decode method make the most sense in that case?

[dasch]

No, you're right – and if the error is already being raised then it's fine 👍

[dasch]

Thanks!