Merge pull request #4114 from zendesk/awoo/secret-visible

Dont error if secret visible key does not exist
zendesk · Aug 5, 2024 · bf47fcd · bf47fcd
2 parents 08a207c + 44a3ad6
commit bf47fcd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/app/controllers/secrets_controller.rb b/app/controllers/secrets_controller.rb
@@ -228,7 +228,7 @@ def failure_response(message)
 
   def find_secret
     @secret = Samson::Secrets::Manager.read(id, include_value: true)
-    @secret[:value] = nil unless @secret.fetch(:visible)
+    @secret[:value] = nil unless @secret[:visible]
   end
 
   def find_writable_project_permalinks

diff --git a/test/controllers/secrets_controller_test.rb b/test/controllers/secrets_controller_test.rb
@@ -526,6 +526,12 @@ def do_update(extras = {})
         assert_template :show
       end
 
+      it "renders when secret only has value key" do
+        Samson::Secrets::Manager.stubs(:read).returns({value: 'test'})
+        get :show, params: {id: secret.id}
+        assert_template :show
+      end
+
       it "renders with unknown project" do
         secret.update_column(:id, 'oops/bar')
         get :show, params: {id: secret.id}