silence #327
Merged
silence #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
requested changes
Mar 8, 2017
There was a problem hiding this comment.
Why not use disable_warnings? https://github.com/intridea/hashie/blob/master/lib/hashie/mash.rb#L72-L79
``` ou are setting a key that conflicts with a built-in method Hashie::Mash#class defined in Kernel. This can cause unexpected behavior when accessing the key via as a property. You can still access the key via the #[] method. ```
|
neat, updated! |
|
👋 Hey this is really spamming our logs. Is there anything I can do to help expedite things? |
|
how about a review ? :D |
|
👍 |
|
v1.14.3 |
| module ZendeskAPI | ||
| # @private | ||
| class SilentMash < Hashie::Mash | ||
| disable_warnings |
There was a problem hiding this comment.
Would have been nice to check for method existence 😄
There was a problem hiding this comment.
update your hashie ... but I guess should bump required version here and yank the previous release ...
There was a problem hiding this comment.
Yeah I found out that I needed to bump hashie but it came as a bit of a surprise!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bquorning