feat!: add new rules for jest, react, and typescript #171
Conversation
BREAKING CHANGE added - @typescript-eslint/no-non-null-asserted-nullish-coalescing - @typescript-eslint/no-restricted-imports - jest/prefer-expect-resolves - jest/prefer-to-be - react/no-namespace
plugins/typescript.js
Outdated
| // disallows using the non-null assertion on the left operand of the nullish coalescing operator | ||
| '@typescript-eslint/no-non-null-asserted-nullish-coalescing': 2, | ||
| // allows to specify new option `allowTypeImport` for path or pattern | ||
| '@typescript-eslint/no-restricted-imports': [2, { | ||
| paths: [], | ||
| patterns: [] | ||
| }] |
There was a problem hiding this comment.
Please note that no-restricted-imports is an Extension Rule. Correct handling for an extension is to zero-out the base eslint rule at the top of this file, and then add the corresponding @typescript-eslint/no-restricted-imports rule with the very same syntax that we see in
Lines 34 to 35 in 7fc5181
There was a problem hiding this comment.
Noted, thanks for sharing this.
There was a problem hiding this comment.
fwiw, it might still be a nice touch to add the no-restricted-imports: 0 to the top of this file just as a documented indicator that we're going with the typescript version of the rule now. Even though they are all 0 throughout 😛
plugins/typescript.js
Outdated
| @@ -190,6 +192,8 @@ module.exports = { | |||
| '@typescript-eslint/no-redeclare': bestPractices['no-redeclare'], | |||
| // disallows invocation of `require()` | |||
| '@typescript-eslint/no-require-imports': 2, | |||
| // allows to specify new option `allowTypeImport` for path or pattern | |||
| '@typescript-eslint/no-restricted-imports': 0, | |||
There was a problem hiding this comment.
Please use '@typescript-eslint/no-restricted-imports': es6['no-restricted-imports'] and knock out the baseline no-restricted-imports by setting it to zero in the top block of this file.
BREAKING CHANGE added
Description
Adding the new rules introduced by the updates to the
jest,reactandtypescript-eslintplugins.Detail
There were three plugins that were updated that introduced new rules:
@typescript-eslint/eslint-pluginversion4.32.0CHANGELOGeslint-plugin-jestversion24.5.0CHANGELOG** There were deprecations made to the rule
jest/prefer-to-be-nullandjest/prefer-to-be-undefinedin favor ofjest/prefer-to-be- more detail can be found in this PReslint-plugin-reactversion7.26.0CHANGELOG