Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency optimize-css-assets-webpack-plugin to v5 #75

Merged
merged 5 commits into from
Sep 3, 2018
Merged

chore(deps): update dependency optimize-css-assets-webpack-plugin to v5 #75

merged 5 commits into from
Sep 3, 2018

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 25, 2018

This Pull Request updates dependency optimize-css-assets-webpack-plugin from v4.0.3 to v5.0.0


Release Notes

v5.0.0

Compare Source

This PR has been generated by Renovate Bot.

@renovate renovate bot force-pushed the renovate/optimize-css-assets-webpack-plugin-5.x branch from 9d2f157 to b0a39f9 Compare July 25, 2018 23:14
@jzempel
Copy link
Member

jzempel commented Jul 25, 2018

@Austin94 this represents a major bump to cssnano which I have yet to do on css-components. I wonder if it's better to take the leap over there before we do it here? We might want to see what happens with this: https://github.com/zendeskgarden/css-components/blob/master/.postcssrc.js#L13-L18

@renovate renovate bot force-pushed the renovate/optimize-css-assets-webpack-plugin-5.x branch from b0a39f9 to 8508473 Compare July 26, 2018 16:45
@austingreendev
Copy link
Contributor

I agree. Lets leave this open as a reminder, but we can handle this on the css-components side.

@renovate renovate bot force-pushed the renovate/optimize-css-assets-webpack-plugin-5.x branch 2 times, most recently from bb58d65 to 93901d8 Compare July 26, 2018 17:05
@renovate renovate bot force-pushed the renovate/optimize-css-assets-webpack-plugin-5.x branch from 93901d8 to 20eed25 Compare July 26, 2018 20:43
jzempel
jzempel requested changes Jul 27, 2018
View reviewed changes
Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My latest commit shows the only solution I can find for forcing options into the cssnano used by optimize-css-assets-webpack-plugin. I don't believe it's acceptable (spreads concerns out). We should wait until the plugin is fixed to honor the new cssnano v4 API.

@jzempel
Copy link
Member

jzempel commented Jul 27, 2018

issue opened here: NMFR/optimize-css-assets-webpack-plugin#69

@renovate
Copy link
Contributor Author

renovate bot commented Jul 27, 2018

PR has been edited

As this PR has been edited, Renovate will stop updating it in order to not cause any conflicts or other problems. If you wish to abandon your edits and have Renovate recreate this PR then you should rename this PR and then close it.

@coveralls
Copy link

coveralls commented Aug 30, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 96.09% when pulling fba38fb on renovate/optimize-css-assets-webpack-plugin-5.x into a40593c on master.

@jzempel
Copy link
Member

jzempel commented Sep 1, 2018

@Austin94 @ryanseddon this is ready for review now. CSS files are building as expected.

@jzempel jzempel merged commit df482e0 into master Sep 3, 2018
@jzempel jzempel deleted the renovate/optimize-css-assets-webpack-plugin-5.x branch September 3, 2018 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanseddon ryanseddon ryanseddon approved these changes

@jzempel jzempel jzempel approved these changes

@austingreendev austingreendev Awaiting requested review from austingreendev

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jzempel @austingreendev @coveralls @ryanseddon @renovate-bot