This repository has been archived by the owner on May 1, 2019. It is now read-only.
Enhancement: Autoload with Composer only #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
feature/autoloading
branch
3 times, most recently
from
67ce2e2
to
5b7eb8b
Compare
localheinz
changed the title
localheinz
changed the title
localheinz
force-pushed
the
feature/autoloading
branch
from
6a5ae15
to
a1ced81
Compare
localheinz
changed the title
|
Rebased, waiting for build, then possibly a merge. /cc @Danielss89 |
| return $client; | ||
| }*/ | ||
| ), | ||
| ); |
There was a problem hiding this comment.
Please move all this to factories so it can be cached, Also, put it in a config file.
There was a problem hiding this comment.
Sure, but not in this PR.
|
+1, like! |
No idea why the module class needs to extend ZfcBase\Module\AbstractModule, is this really necessary?
localheinz
force-pushed
the
feature/autoloading
branch
2 times, most recently
from
6ce34cd
to
d6962ad
Compare
GeeH
added a commit
that referenced
this pull request
Dec 4, 2014
Enhancement: Autoload with Composer only
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it's 2014.