-
Notifications
You must be signed in to change notification settings - Fork 159
Fix: Added Factories and Inject dependencies for ViewHelper and Module Service #263
Conversation
update base
fork sync
Conflicts: module/ZfModule/src/ZfModule/Module.php
The build failed because of CS issues. |
Can you also try to avoid merge commits and just rebase on top of
first before checking out a new branch. Thank you! |
@localheinz i will keep that in my mind 👍 |
@localheinz is this merge commit a problem and needs some interaction? |
*/ | ||
protected $moduleMapper; | ||
public function __construct(\ZfModule\Mapper\Module $moduleMapper, Client $githubClient) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a suggestion - can you import ZfModule\Mapper
? Helps avoiding FCQNs!
'zfmodule_service_module' => 'ZfModule\Service\Module', | ||
), | ||
'aliases' => array( | ||
'zfmodule_service_module' => 'ModuleService' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I'd avoid using aliases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just realize the service name is only used once. so the alias is useless what is a bp for service names ZfModule\Service\Module
or zfmodule_service_module
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably depends - if we were using PHP5.5, I'd go for ZfModule\Service\Module::class
. Can you leave the service identifier as it was - zfmodule_service_module
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
Thank you, @ins0! |
Fix: Added Factories and Inject dependencies for ViewHelper and Module Service
@localheinz
This PR extends your PR #262 and add factories for all necessary viewhelper and the module service