Fix: removed unnecessary api call

[ins0]

Fixes unnecessary API call to Github

[localheinz]

@ins0

I'd prefer to see ZfModule/Controller/IndexController.php#L66 removed - because why make a call to an API if there are chances to return before the expression result can be used, such as ZfModule/src/ZfModule/Controller/IndexController.php#L69-L71?

What do you think?

Good catch, though!

[ins0]

that also was also my first thought - but the api call on L66 is currently necessary because of the current cache logic $response->getStatusCode() == 304 - otherwise we don't know, if the cache should be used or not. or have i missed something?

but i agree, the current cache implementation works - but looks awful.
i would prefer to see a smart reference there and a non persistent cache that gets tossed after x time. so we are not forced to call the api every time we want to access a repository.

[localheinz]

@ins0

👍