This repository has been archived by the owner on May 1, 2019. It is now read-only.
[WIP] Fix/Added escape helper to view output #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ins0
commented
Jan 22, 2015
ins0
commented
| @@ -26,13 +26,13 @@ | |||
| <div class="span6 module-author"> | |||
| <div class="row-fluid"> | |||
| <div class="span3"> | |||
| <img src="<?php echo $module->getPhotoUrl()?>" alt="<?php echo $module->getOwner()?>" class="avatar"> | |||
| <img src="<?php echo $module->getPhotoUrl()?>" alt="<?php echo $this->escapeHtml($module->getOwner()); ?>" class="avatar"> | |||
There was a problem hiding this comment.
Use htmlAttr escaper on the getPhotoUrl please
|
didn't notice this helper LMAO, thanks @GeeH will update this |
ins0
changed the title
GeeH
added a commit
that referenced
this pull request
Jan 23, 2015
[WIP] Fix/Added escape helper to view output
|
Thank you very much @ins0 :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.