Skip to content
This repository has been archived by the owner on May 1, 2019. It is now read-only.

Enhancement: Increase coverage for ZfModule\Service\Module #388

Merged

Conversation

localheinz
Copy link
Member

This PR

  • streamlines existing test names
  • adds tests for ZfModule\Service\Module::isModule()
  • increases readability a bit
  • fixes a typo
  • adds tests for ZfModule\Service\Module::register()
  • increases readability, inlines and renames variables and parameters, updates doc-block

@localheinz localheinz self-assigned this Feb 15, 2015
@localheinz localheinz changed the title [WIP] Enhancement: Increase coverage for ZfModule\Service\Module Enhancement: Increase coverage for ZfModule\Service\Module Feb 15, 2015
@localheinz localheinz changed the title Enhancement: Increase coverage for ZfModule\Service\Module [WIP] Enhancement: Increase coverage for ZfModule\Service\Module Feb 15, 2015
@localheinz localheinz force-pushed the feature/module-service-coverage branch 2 times, most recently from 5c8c8a7 to d81c777 Compare February 15, 2015 23:05
@localheinz localheinz force-pushed the feature/module-service-coverage branch from d81c777 to a76d9b2 Compare February 15, 2015 23:06
@localheinz localheinz force-pushed the feature/module-service-coverage branch from 770486b to 1d2306b Compare February 15, 2015 23:11
@localheinz localheinz changed the title [WIP] Enhancement: Increase coverage for ZfModule\Service\Module Enhancement: Increase coverage for ZfModule\Service\Module Feb 15, 2015
Ocramius added a commit that referenced this pull request Feb 16, 2015
Enhancement: Increase coverage for ZfModule\Service\Module
@Ocramius Ocramius merged commit 4bf2466 into zendframework:master Feb 16, 2015
@Ocramius
Copy link
Member

Merged, thanks!

@localheinz localheinz deleted the feature/module-service-coverage branch February 16, 2015 08:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants