Enhancement: Also search by owner, split query into words #394
Conversation
localheinz
force-pushed
the
feature/search
branch
2 times, most recently
from
4be0604
to
54167b9
Compare
localheinz
changed the title
| /* @var Sql\Where $where */ | ||
| $where | ||
| ->like('name', $like) | ||
| ->or |
There was a problem hiding this comment.
(Yes, I know that's how you do it with Zend\Db :-( )
There was a problem hiding this comment.
ahah migration to doctrine in this moment is unthinkable :P
There was a problem hiding this comment.
Harhar! Yes, it's ugly.
Happy to migrate to Doctrine!
Things we could benefit from, then:
- Doctrine migrations
- combination of
breerly/factory-girl-phpandfzaninotto/Fakerfor integration tests
localheinz
force-pushed
the
feature/search
branch
4 times, most recently
from
769e5d5
to
bf8cc2c
Compare
localheinz
changed the title
|
nice! |
|
But actually di wrapper should show the package di-wrapper, which it still doesn't seem to do according to the screenshot. |
|
Not sure if it's there, hang on a minute. |
|
I didn't have it in my local copy of the database, sorry! |
localheinz
force-pushed
the
feature/search
branch
from
7299327
to
b4a921a
Compare
|
Also made some adjustments to the way modules are displayed. I think it makes a lot more sense to always display vendor and package, not just the package name. |
|
Ok, sounds good, looking forward to seeing it live. |
| @@ -22,10 +22,9 @@ | |||
| <div class="col-xs-7 col-sm-6"> | |||
| <p> | |||
| <a href="<?php echo $this->url('view-module', ['vendor' => $this->escapeUrl($module->getOwner()), 'module' => $this->escapeUrl($module->getName())]) ?>"> | |||
| <strong><?php echo $this->escapeHtml($module->getName()) ?></strong> | |||
| <strong><?php echo $this->escapeHtml($module->getOwner()); ?>/<?php echo $this->escapeHtml($module->getName()); ?></strong> | |||
There was a problem hiding this comment.
Actually, what I would like to do would be a simplification of displaying an item, this definitely shouldn't be repeated all over the place!
You know, a module should probably have no more than two public views
- side bar
- results (and the live-search thingy)
However, in reality I would even want to go as far as to have a search similar to what all of you know from packagist, what do you think?
|
Needs a rebase |
localheinz
force-pushed
the
feature/search
branch
from
7394d8c
to
2f1240f
Compare
|
Rebased, waiting for the build to pass. |
localheinz
force-pushed
the
feature/search
branch
2 times, most recently
from
ddb6c40
to
75010c7
Compare
localheinz
force-pushed
the
feature/search
branch
from
75010c7
to
716bafe
Compare
Enhancement: Also search by owner, split query into words
|
@localheinz awesome, merged! \o/ |
|
Thanks a lot, @Ocramius! I'm very happy to move forward with this thing! |
This PR
ZfModule\Mapper\Modulea bitnameanddescription, but also inownerFixes #153.
Searching by owner
Before
After
Searching with multiple words
Before
After
Display of vendor/package vs just package
Before
After