This repository has been archived by the owner on May 1, 2019. It is now read-only.
Enhancement: Streamline layouts and fix-up content #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
fix/layouts
branch
2 times, most recently
from
21d5685
to
2ef4438
Compare
localheinz
force-pushed
the
fix/layouts
branch
from
2ef4438
to
8b70358
Compare
localheinz
changed the title
|
Actually, I'd be very happy to reiterate on this! Since @ins0 has updated to Twitter Bootstrap 3, we should use it as much as we can. The current design looks too old. Also, I suggest to use icons, for example, Font Awesome |
| @@ -2,53 +2,53 @@ | |||
|
|
|||
| <html lang="en"> | |||
| <head> | |||
| <?php echo $this->headTitle('ZF2 Modules')->setSeparator(' - ')->setAutoEscape(false) ?> | |||
| <?php $this->headTitle('ZF2 Modules')->setSeparator(' - ')->setAutoEscape(false); ?> | |||
| <?php echo $this->headTitle(); ?> | |||
There was a problem hiding this comment.
I liked the previous approach better (easier to read, imo)
Ocramius
added a commit
that referenced
this pull request
Feb 18, 2015
Enhancement: Streamline layouts and fix-up content
|
Merged, thanks |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to streamline the existing layouts in order to reduce duplication, so we can move on and actually change it without having to do in two places.
Before
After