This repository has been archived by the owner on May 1, 2019. It is now read-only.
Enhancement: Use a collapsable Twitter Bootstrap navbar #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
feature/navbar
branch
from
2444a53
to
c838a0d
Compare
localheinz
force-pushed
the
feature/navbar
branch
from
c838a0d
to
303f6f4
Compare
|
👍 |
1 similar comment
|
👍 |
| <div class="navbar-header"> | ||
| <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#bs-example-navbar-collapse-1"> | ||
| <span class="sr-only">Toggle navigation</span> | ||
| <span class="icon-bar"></span> |
There was a problem hiding this comment.
This stuff is basically the infamous 🍔 icon right here:
For reference, this mostly matches the first example here: http://getbootstrap.com/components/#navbar
There was a problem hiding this comment.
Yeah, so 3 repeated <span/>: comment it for clarity, maybe? :)
|
Shall we use a black one and use the same link colours to make the step a bit smaller? |
Not following the question, can you rephrase it? |
|
Ok, instead of the
shall we use an
as it is closer to the current navigation? |
|
I think this one is fine. Waiting for travis and then I'm merging :) |
Ocramius
added a commit
that referenced
this pull request
Feb 24, 2015
Enhancement: Use a collapsable Twitter Bootstrap navbar
|
👍 |
|
Thank you, @Ocramius! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Signed out
Before
After
Signed In
Before
After
Smaller Screens
Before
After