Enhancement: Removed asset manager #433
Conversation
|
👍 |
| @@ -10,7 +10,6 @@ | |||
| "ezyang/htmlpurifier": "4.6.*", | |||
| "monolog/monolog": "~1.12", | |||
| "php": "~5.5", | |||
| "rwoverdijk/assetmanager": "1.3.*", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
done, a question - what is the point that the composer.lock file is in the version control?
There was a problem hiding this comment.
@ins0 the composer.lock MUST be under version control for deployments
| @@ -1,4 +1 @@ | |||
| img | |||
| css | |||
| js | |||
| favicon.ico | |||
There was a problem hiding this comment.
I think this .gitignore can be removed, can't it?
| @@ -1,4 +0,0 @@ | |||
| img | |||
There was a problem hiding this comment.
Can we actually use bower for this stuff?
There was a problem hiding this comment.
👍, but out of scope of this PR, I think!
There was a problem hiding this comment.
We are replacing with directly committed assets, heh
There was a problem hiding this comment.
Nvm, we are just moving the assets. But yes, we should use bower here.
Enhancement: Removed asset manager
|
🚢 |
|
thanks @localheinz and @Ocramius |
|
Thanks!!!! @ins0 👍 👍 |
This removes the asset manager. In the current state the asset manager don't provides real effort nor we use multi module public folders.