This repository has been archived by the owner on May 1, 2019. It is now read-only.
Fix: organizationAction() should be listAction() #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2015
|
Requires rebasing |
localheinz
force-pushed
the
fix/organization-vs-list
branch
from
ced5a7b
to
50d622a
Compare
|
Rebased, thank you for reviewing! |
Ocramius
added a commit
that referenced
this pull request
Mar 6, 2015
Fix: organizationAction() should be listAction()
|
👍 |
|
Thank you, @Ocramius! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Controller\IndexController::organizationAction()tolistAction()because that's what is in the route name, and also, what the action does, that is, list modules💡 Controller should probably be named differently as well, e.g.,
ModuleController