Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Fix for php72 (object is a reserved keyword) #36

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Fix for php72 (object is a reserved keyword) #36

merged 1 commit into from
Dec 11, 2017

Conversation

remicollet
Copy link
Contributor

This allow to run test suite against 7.2 (using PHPUnit 5.7)

@remicollet remicollet mentioned this pull request Oct 20, 2017
Open
@remicollet
Copy link
Contributor Author 

$ TESTS_ZEND_BARCODE_PDF_SUPPORT=1 vendor/bin/phpunit 
PHPUnit 5.7.23 by Sebastian Bergmann and contributors.

.............................................................   61 / 1263 (  4%)
.........................S...................................  122 / 1263 (  9%)
.......................S.....................................  183 / 1263 ( 14%)
..........................S..................................  244 / 1263 ( 19%)
..................................S..........................  305 / 1263 ( 24%)
....................................S........................  366 / 1263 ( 28%)
...................................S.........................  427 / 1263 ( 33%)
................................S............................  488 / 1263 ( 38%)
.............................S...............................  549 / 1263 ( 43%)
...........................S.................................  610 / 1263 ( 48%)
................S............................................  671 / 1263 ( 53%)
..............S..............................................  732 / 1263 ( 57%)
..................S..........................................  793 / 1263 ( 62%)
................S............................................  854 / 1263 ( 67%)
..............S..............................................  915 / 1263 ( 72%)
............S................................................  976 / 1263 ( 77%)
.........S................................................... 1037 / 1263 ( 82%)
.......S..................................................... 1098 / 1263 ( 86%)
......S...................................................... 1159 / 1263 ( 91%)
............................................................. 1220 / 1263 ( 96%)
...........................................                   1263 / 1263 (100%)

Time: 751 ms, Memory: 16.00MB

OK, but incomplete, skipped, or risky tests!
Tests: 1263, Assertions: 2240, Skipped: 18.

@remicollet
Copy link
Contributor Author

I don't understand the travis failure with outdated PHPUnit, but seems not related to these changes

@froschdesign froschdesign mentioned this pull request Oct 24, 2017
Closed
@michalbundyra michalbundyra mentioned this pull request Oct 25, 2017
Merged
@weierophinney weierophinney merged commit 70c2981 into zendframework:master Dec 11, 2017
weierophinney added a commit that referenced this pull request Dec 11, 2017
@weierophinney
Merge pull request #36 from remicollet/issue-php72
3f3cb15 
Fix for php72 (object is a reserved keyword)
weierophinney added a commit that referenced this pull request Dec 11, 2017
@weierophinney
Adds CHANGELOG for #36
e3f2648
weierophinney added a commit that referenced this pull request Dec 11, 2017
@weierophinney
Merge branch 'hotfix/36'
04dd5f6 
Close #36
weierophinney added a commit that referenced this pull request Dec 11, 2017
@weierophinney
Merge branch 'hotfix/36' into develop
ca1aa13 
Forward port #36
@weierophinney
Copy link
Member

Thanks, @remicollet!

weierophinney added a commit that referenced this pull request Dec 11, 2017
@weierophinney
Merge pull request #38 from webimpress/update
5ca8039 
PHP 7.2 + QA Tools - follow up #25, #29, #31, #36

Conflicts:
	.travis.yml
	composer.json
@weierophinney weierophinney mentioned this pull request Dec 31, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remicollet @weierophinney @froschdesign