This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
[WIP] Refactor with new service and event manager #22
Merged
weierophinney
merged 2 commits into
zendframework:develop
from
ezimuel:feature/refactor-service-event-manager
Oct 29, 2015
Merged
[WIP] Refactor with new service and event manager #22
weierophinney
merged 2 commits into
zendframework:develop
from
ezimuel:feature/refactor-service-event-manager
Oct 29, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@weierophinney I solved all the error in the unit tests except for this one:
Can you have a look? Thanks. |
One quick comment: zend-mvc standardizes on |
@@ -42,25 +47,7 @@ class PatternPluginManager extends AbstractPluginManager | |||
protected $shareByDefault = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh - found another slight BC break in SM v3: this becomes $sharedByDefault
(note shared
vs share
). That change fixes a few errors.
weierophinney
added a commit
that referenced
this pull request
Oct 29, 2015
…nager [WIP] Refactor with new service and event manager
weierophinney
added a commit
that referenced
this pull request
Oct 29, 2015
weierophinney
added a commit
that referenced
this pull request
Oct 29, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the refactoring of zend-cache using the new zend-servicemanager and zend-eventmanager of ZF3.
NOTE: this PR is a work in progress, please don't merge!
To do: