This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Add support for empty values set with IN predicate #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezimuel
suggested changes
Feb 28, 2017
src/Sql/Predicate/In.php
Outdated
| @@ -122,9 +122,10 @@ public function getExpressionData() | |||
| foreach ($values as $argument) { | |||
| list($replacements[], $types[]) = $this->normalizeArgument($argument, self::TYPE_VALUE); | |||
| } | |||
| $values = count($values) > 0 ? array_fill(0, count($values), '%s') : []; | |||
There was a problem hiding this comment.
Why this? array_fill() returns [] if $values === []. Please remove this change, the previous code is ok.
|
@ezimuel Not with versions of PHP < 5.6. My code is here to avoid a warning with those older versions of PHP. |
ezimuel
approved these changes
Feb 28, 2017
|
@nanawel ok, I see the point. Makes no sense to add a check for PHP < 5.6. The code looks good to me. I'm going to merge in a while. Thanks for your contribution! |
|
And thanks to you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Original PR #196)
It should be possible to construct a IN predicate with empty values set.
Of course this code will most likely never be written as is but the content of the set can instead be the result of a calculation.
It's not possible with the current code because of the
if ($valueSet)in the constructor and the missing default value in the field definition above, which leads to the following error on line 122 when predicate is built:Empty sets are supported by some DBMS (SQLite for example) and in that case are the equivalent of
WHERE FALSE(since no result can be part of an empty set...).